Skip to content

Conversation

@yuchenshi
Copy link
Member

@yuchenshi yuchenshi commented Oct 21, 2021

To include the fix in firebase/firebase-functions#838, fixing a hard to debug issue when both database and functions emulators are started.

Description

Scenarios Tested

Sample Commands

To include the fix in firebase/firebase-functions#838, causing a hard to debug issue when both database and functions emulators are started.
@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Oct 21, 2021
Copy link
Contributor

@bkendall bkendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is effectively a breaking change, let's hold off on this until we get to a major version

@bkendall bkendall changed the base branch from master to next December 13, 2021 21:30
@bkendall bkendall added this to the v10.0.0 milestone Dec 13, 2021
@bkendall bkendall merged commit a5ff8d5 into next Dec 14, 2021
@bkendall bkendall deleted the yuchenshi-patch-1 branch December 14, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants